feat: Catalogue tab on the Feed engine — sync feed + search feed - #236
Open
danieltmbr wants to merge 1 commit into
Open
feat: Catalogue tab on the Feed engine — sync feed + search feed#236danieltmbr wants to merge 1 commit into
danieltmbr wants to merge 1 commit into
Conversation
The catalogue hosts two feeds: browse refresh runs the SyncGroup through an input-less .catalogue feed (status line, pull-to-refresh, empty view + retry all ride FeedState), and search+paging rides the .catalogueSearch feed with its typed CatalogueSearchQuery (term + category types + languages, all sent to the server). - Pull-to-refresh restarts page 1 of the current session — sync for browse, the active search otherwise; fetches fire immediately (model supersedes) - The flash-fix choreography collapses to one task keyed on the search query (filter changes restart it) plus one revision observer for load-more upserts - Two feeds share the subtree, so the list scopes its components explicitly via .feedControls; row-driven paging deliberately not applied — engine results aren't createdAt-ordered - CatalogueModel slims to the category filter; the old refresh action, env keys, and status/empty views retire Completes the Feed migration — tree now matches the reference branch. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack 4/4 (on #235). Completes the Feed migration — this tree matches the reference branch (#229's successor work) apart from files main is already ahead on.
SyncGroupthrough an input-less.cataloguefeed (status line, pull-to-refresh, empty view + retry all rideFeedState); search + paging rides.catalogueSearchwith a typedCatalogueSearchQuery— term, category types, and languages all reach the server nowrevisionobserver for load-more upserts (comment explains the loop it avoids).feedControls; row-driven paging deliberately not applied (engine results aren't createdAt-ordered)CatalogueModelslims to the category filter; old refresh action/env keys/status/empty views retireVerification
swift test --package-path app-core— 49 tests greengit diff— only fix: stop JWT bearer-header ERROR log flood on unauthenticated requests #232's web-auth files, where main is ahead)🤖 Generated with Claude Code